Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object-oriented OTP library #1

Open
1 of 5 tasks
jakelee8 opened this issue Apr 24, 2017 · 3 comments
Open
1 of 5 tasks

Object-oriented OTP library #1

jakelee8 opened this issue Apr 24, 2017 · 3 comments

Comments

@jakelee8
Copy link
Contributor

jakelee8 commented Apr 24, 2017

@markbao @railsstudent This rewrite of Speakeasy drops legacy support and simplifies usage by including sensible quickstart defaults. By default:

  • Two-sided window for both TOTP and HOTP
  • Default window=1
  • Default period=30, renamed from step to match URL parameter
  • API only accessible via new TOTP({...}) and new HOTP({...}).

Issues:

  • Type checking unnecessary in TypeScript, but not available in plain JS. Add type checking or assume developer knows best? Considering number of usage issues in Speakeasy...
  • Update documentation
  • Update build/CI
  • Convert floating point inputs to integers, test floating point inputs, e.g. {time: 100.123}
  • Release libotp aka Speakeasy 3.0

To build and test:

npm install
npm run prepare
npm run test
@railsstudent
Copy link
Contributor

What needs to be done in the current stage?

@jakelee8
Copy link
Contributor Author

jakelee8 commented May 9, 2017 via email

@railsstudent
Copy link
Contributor

@markbao @mikepb I will work on update documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants