You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The hack was put in via 678c4ee when astropy.io.fits went to lazy loading (I think it was astropy/astropy#6082). I found an old note to investigate further, which I never got to. I vaguely remember looking at stpyfits and concluded that some significant refactoring might be necessary if we're going to do this the right way.
However, maybe removing the hack is not worth the time given that everything is working fine and the hack was a simple one-liner. But then again, if this hack breaks in the future or we find that it is no longer sufficient for "big data" or whatever, we might need to revisit, so hopefully this issue will be helpful then.
Notes to reproduce the problem without this hack
Example given by @stsci-hack on 2017-06-13, "The image I used to demonstrate the problem was nothing special, simply a RAW ACS image... This problem was easily reproduced using any RAW FITS file retrieved from the archive."
The hack was put in via 678c4ee when
astropy.io.fits
went to lazy loading (I think it was astropy/astropy#6082). I found an old note to investigate further, which I never got to. I vaguely remember looking atstpyfits
and concluded that some significant refactoring might be necessary if we're going to do this the right way.However, maybe removing the hack is not worth the time given that everything is working fine and the hack was a simple one-liner. But then again, if this hack breaks in the future or we find that it is no longer sufficient for "big data" or whatever, we might need to revisit, so hopefully this issue will be helpful then.
Notes to reproduce the problem without this hack
Example given by @stsci-hack on 2017-06-13, "The image I used to demonstrate the problem was nothing special, simply a RAW ACS image... This problem was easily reproduced using any RAW FITS file retrieved from the archive."
The text was updated successfully, but these errors were encountered: