Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposure pipeline documentation out-of-date #1524

Open
braingram opened this issue Nov 15, 2024 · 0 comments
Open

Exposure pipeline documentation out-of-date #1524

braingram opened this issue Nov 15, 2024 · 0 comments

Comments

@braingram
Copy link
Collaborator

https://roman-pipeline.readthedocs.io/en/latest/roman/pipeline/exposure_pipeline.html
generated from (to get a permalink):

--use_ramp_jump_detection boolean default=True

Describes the pipeline as accepting a --use_ramp_jump_detection argument,. Attempting to pass this to strun results in:
strun: error: unrecognized arguments: --use_ramp_jump_detection=False

The documentation doesn't describe save_calibrated_ramp.

The docs also mention accepting a single datamodel as an input but doesn't describe passing an association.

The output is not described as a list of models (the pipeline doesn't return a single model but may return a list with a single model).

The documentation also doesn't describe how the pipeline handles fully saturated exposures. It appears to "short-circuit" on the first fully saturated model returning only models processed up until that point and not continuing (see #1523).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant