Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update photom schema #459

Open
tddesjardins opened this issue Oct 4, 2024 · 2 comments
Open

Update photom schema #459

tddesjardins opened this issue Oct 4, 2024 · 2 comments
Assignees

Comments

@tddesjardins
Copy link

In the photom schema, we have under phot_table an entry for each optical element that currently contains the following:

  • photmjsr
  • uncertainty
  • pixelareasr

I suggest we add to this the following fields (welcome feedback here):

  • wavelength
    • title: Throughput Wavelength Array (micron)
    • description: Array of wavelengths in units of microns at which the throughput has been measured.
    • dtype: array
    • items:
      • dtype: float
  • throughput
    • title: Throughput Array (unitless)
    • description: Array of unitless throughput measurements. The throughput is the integrated throughput including all elements of the optical chain from the entrance aperture to the detector pixels including reflectivity, bandpass throughput, and detector quantum efficiency. For the spectral elements GRISM and PRISM, this corresponds to the first-order of the dispersed spectrum.
    • dtype: array
    • items:
      • dtype: float

One thing I have not figured out yet is how to store the additional zeroth-order throughput of the grism which we additionally have. Any suggestions for that are welcome. Maybe an optional field throughput_zero ?

@schlafly
Copy link
Collaborator

schlafly commented Oct 4, 2024

The Goddard throughput files are in effective area, which I find kind of nice. This is degenerate at some level with photmjsr, but all things being equal, I'd rather have the normalization in the throughput as well. Is there a reason not to include that?

Making sure I understand---the zeroth order grism is a ~direct image with weird-ish but fairly nominal PSF? Do higher grism orders come in as well at some very low amplitude?

At some level this is vaguely analogous to ghosts in direct imaging, which I feel like we usually do not include in the PSF or throughput curves, arguing that they are uncertain and small. In that context, one option is to not include that information. But I gather that the amplitudes are larger for the grism zeroth order data and we should include it.

I don't have a good idea there. I have a vague preference for not complicating the schema, and instead adding a new "filter" that is "grism_order_zero" that gets all of the information. It's unclear what we would do with that information in romancal, but at least the data would be present in the reference files.

@PaulHuwe PaulHuwe self-assigned this Oct 6, 2024
@stscijgbot-rstdms
Copy link
Collaborator

This issue is tracked on JIRA as RAD-178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants