Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks to be transferred here from jdat_notebooks #1

Open
camipacifici opened this issue Apr 5, 2024 · 3 comments
Open

Notebooks to be transferred here from jdat_notebooks #1

camipacifici opened this issue Apr 5, 2024 · 3 comments

Comments

@camipacifici
Copy link
Collaborator

Notebook Name:

None

Description

Here is a list of notebooks that are primarily for running the JWST pipeline and are at the moment stored in jdat_notebooks:

@camipacifici
Copy link
Collaborator Author

Others that are still in PR form on jdat_notebooks:

@drlaw1558
Copy link
Collaborator

drlaw1558 commented Apr 5, 2024

Thanks @camipacifici
Some thoughts quickly on those specific notebooks:

  • MRS Mstar notebook: Should not be migrated. Extremely out of date and not the right notebook for general running of the MRS pipeline. Propose deletion.
  • MRS detector-based extraction: Should not be migrated as this is an alternate-processing method outside the pipeline. Propose remaining in JDAT.
  • NIRISS AMI binary: Mix of generating MIRAGE simulations (should not migrate) and running pieces of the pipeline. Propose action to NIRISS team to develop new notebook targeted at goals of this repo, then deleting these on JDAT.
  • NIRISS imaging: Very close to fulfilling needs of this repo. Propose working with NIRISS team to adapt and migrate.
  • Preimaging notebooks: These are based on simulated data and/or pieces of the pipeline, and are thus inappropriate for this repo. Propose deleting.
  • NIRSpec IFU demos: Not yet in the right format for this repo, but consistent with the goal. Propose working with NIRSpec team to adapt and migrate a single notebook (not multiple per mode).
  • NIRSpec NSclean demos: Not appropriate for this repo as it focuses only on a single step. Propose remaining in JDAT or moving to caveat examples repo.
  • NIRISS WFSS examples: Not currently in the right format for this repo, but consistent with the goal. Propose working with NIRISS team to adapt and migrate as a single notebook.

@sosey
Copy link
Member

sosey commented Apr 9, 2024

I've also asked the teams themselves to identify the notebooks that should be migrated and make a jira ticket for them

sosey pushed a commit that referenced this issue Sep 26, 2024
mgough-970 pushed a commit that referenced this issue Nov 14, 2024
updates after technical review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants