Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDB] Mob difference isn't highlighted #19

Open
CheffieGithub opened this issue Mar 7, 2023 · 5 comments
Open

[MDB] Mob difference isn't highlighted #19

CheffieGithub opened this issue Mar 7, 2023 · 5 comments

Comments

@CheffieGithub
Copy link

Description

When comparing diff between map changes, mobs aren't highlighted in red.

Steps to reproduce

  1. make a mapping change that deals with mobs
  2. view the diff
  3. cry when you can't tell what mobs are changed

Expected Behavior

All diff is highlighted for ease of viewing and review

Additional Information & Screenshots

image

Case of object critter to mob critter

@AffectedArc07
Copy link
Member

The old and new images are the same?

@CheffieGithub
Copy link
Author

Yes that's the issue because they aren't the same, left the critter is an object on the right its a mob

@AffectedArc07
Copy link
Member

The diff image can only compare visual changes, the exact same issue occurs for VV edits.


Its unlikely this will ever be fixed, paging @MCHSL and @jupyterkat for thoughts.

@jupyterkat
Copy link
Collaborator

this would be a huge rework of how the diff is rendered, all for a tiny vv edit

@CheffieGithub
Copy link
Author

well thats too bad then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants