Fully parsed tx types

[lrettig]

Right now the API only returns parsed "raw" transactions that include the principal, template, and method selector but not the method payload nor the parsed payload (which for a 'Send' tx would include recipient and amount):

api/spacemesh/v1/types.proto

Lines 45 to 58 in eebe59f

	// An immutable Spacemesh transaction.
	// do not include mutable data such as tx state or result.
	message Transaction {
	bytes id = 1;
	AccountId principal = 2;
	AccountId template = 3;
	uint32 method = 4; // this is actually limited by uint8, but no type for that.
	Nonce nonce = 5;
	LayerLimits limits = 6;
	uint64 max_gas = 7;
	uint64 gas_price = 8;
	uint64 max_spend = 9;
	bytes raw = 10;
	}

This makes reading tx data unnecessarily difficult for clients. Add one or more fully-parsed tx types (for spawn, send, etc.).

[Avionic23]

Hi, @lrettig. I've been trying to decode the raw transaction with 'go-scale' library into different data structures like Spend, SpendBody, SpendPayload, SpendArguments. Unfortunately , none of those has worked. I'm kindly asking if it's possible to decode address of the receiver from raw transaction. Also, I'd like to know what fields are included in the raw transaction and in which order because I've found several sources with different data structures and I'm not sure which one is correct. Thanks

[lrettig]

This is being handled in APIv2 now in #319; see the work in progress here: https://github.com/spacemeshos/api/pull/319/files#diff-8ebf744ee0115b17bf0e41111f7f3d9ea7c8b4205532e81f9a3e287e5c3154b9.

@Avionic23 please see https://github.com/spacemeshos/wiki/wiki/Integration-guide#transactions. The authoritative code you're looking for lives in https://github.com/spacemeshos/go-spacemesh/blob/develop/genvm/vm.go. It's definitely possible to parse a raw tx into a tx type and to parse the arguments as you describe; go-spacemesh does exactly this. We don't yet have a clean SDK that makes doing this easy but hopefully we will soon. Let me know if you still have questions.

[Avionic23]

Hey, @lrettig. Thank you for your help. I reviewed https://github.com/spacemeshos/go-spacemesh/blob/develop/genvm/vm.go and noticed that the addresses are actually 24 bytes long, but in go-scale they are still 20 bytes long. I assume that's the reason because after replacing [20]byte address to types.Address (which is underlying [24]byte data type) the receiver and amount arguments were successfully parsed.