-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip asset inclusion during installation when the assets don't exist #45
Comments
We should add some options to the command I thinks, like: |
What about adding a conditional when loading the files instead? When generating a new extension one may not know from the beginning if assets will be needed... when updating an extension one would need to check if assets files exist and choose the right generator option - but there's still a chance that some manual tweaking would be required, as JS files may be there and CSS not 🤔 If assets need to be introduced later, one may not know that the easiest way to have them loaded is to rerun the solidus generator, and so would end up spending time trying to figure out the problem and how to load them. I think that having the loaders always in place with conditional loading helps with consistency and would avoid much (if not all) active developer intervention. |
An extension without assets will fail specs because the
test_app
is always created requiring the assets (even if they don't exist).The text was updated successfully, but these errors were encountered: