Add TypeScript support and Use preset-env #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
env-and-typescript
branch
from
ba01441
to
34a84bc
Compare
aminya
commented
May 14, 2021
|
This package should be focused on solid support in jest rather than a general solution. Let's not bloat it and instead continue to give the consumer control over what additional transforms are performed. |
|
I tend to agree with @maxmilton. I'd love to hear more opinions but I'm inclined to close this one. |
|
As I said, we can put this behind a config, and move the dependencies to optionalDependencies. If the improvements are composable there is no need to avoid them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
I added these extras by default. However, we can put them behind a
process.env.BABEL_EXTRASconfig (or a new set of presets) if you prefer that the default config only use babel-solid-js