Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build graph is incorrect when build an optimized segment sequence. #272

Open
OTime-star opened this issue Sep 14, 2021 · 2 comments
Open

Comments

@OTime-star
Copy link

In the encoding process, we will construct a graph, and then use the single-source shortest path algorithm to find the optimal segment sequence, but the constructed graph seems to be problematic.

Keep other parameters as default, and then encode "ABCDEF123", you will get the following graph(Byte mode is omitted).
image
The cost from node ("ABCDEF[A]") to node ("123[A]") is 16, which is wrong, it should be 17.

@soldair
Copy link
Owner

soldair commented Oct 14, 2021

If you would like to take a shot at making this work more correctly I'm happy to take a look at a pr

@OTime-star
Copy link
Author

I created the PR, it is here #273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants