-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG isn't really scalable #220
Comments
hey i would totally be ok with switching to rects. this was a contribution to begin with and im happy to accept another if you're willing. |
That sounds fun! I'll take a crack at it. |
Hello @bobspace At first one question: Where and how do you scale the svg? Possible solutions:
I have both already locally, pull request will follow. UPDATE: Regards Frank |
Looking at the SVG output produced by the
toString
method in my browser, the markup is a bunch ofpath
segments rather thanrect
s, so when you try to actually scale it it turns into a bunch of skinny lines far apart from one another instead of a bigger version of the same QR code.Rendering in
rect
s would be more verbose, but would be massively more useful and actually scale.Here's an example output, scaled:
The text was updated successfully, but these errors were encountered: