Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package manager to DiagnosticView #840

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

p-malecki
Copy link
Contributor

This PR adds a package manager status info to the DiagnosticView, this update will help identify issues from using the wrong package manager, especially when multiple lock files are present in a workspace.

It also introduces a new details field to the DependencyStatus type. This field stores the name of the detected package manager and can also hold version numbers or other relevant details for future needs.

How Has This Been Tested:

  • Tested on project with various package manager configurations (supported, unsupported, installed, uninstalled) set in the launch settings.
  • Tested on project without package manager lock files and with different lock files (yarn.lock, package-lock.json, pnpm-lock.yaml, bun.lockb).
  • Verified that an error is displayed in the Diagnostic view when no package manager is installed.

Screenshots:

Screenshot 2024-12-09 at 23 44 58 Screenshot 2024-12-09 at 23 45 38 Screenshot 2024-12-09 at 23 46 31

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 10:47pm

Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@p-malecki p-malecki merged commit 35f97c4 into main Dec 10, 2024
4 checks passed
@p-malecki p-malecki deleted the @p-malecki/add-package-manager-info-to-diagnostics branch December 10, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants