Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab 5 #4

Open
BertLisser opened this issue Oct 12, 2018 · 1 comment
Open

Lab 5 #4

BertLisser opened this issue Oct 12, 2018 · 1 comment

Comments

@BertLisser
Copy link

BertLisser commented Oct 12, 2018

Exercise 1. Complements for the good documentation.
Exercise 2. Very good an well documented but refactoring can be more complete.
In many more places is it possible to replace Constraints by [Position].
For example

type Node = (Sudoku,[Position])
prune :: (Row,Column,Value)
      -> [Position] -> [Position]
constraints :: Sudoku -> [Position]

Exercise 4
Where is the test that the solution is unique?

Exercise 5
There must be something wrong. I see nearly the same code as in exercise 4. But running Main works well.

@p-kostic
Copy link
Member

This is certainly true and we completely glanced over it! What will be the impact on the grading for notions like these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants