From a5d23685123fe51e175144b9a83d7833cead2a22 Mon Sep 17 00:00:00 2001
From: Damien Arrachequesne <damien.arrachequesne@gmail.com>
Date: Wed, 9 Oct 2024 18:56:59 +0200
Subject: [PATCH] ci: ignore tests when publishing to npm (bis)

`tags-ignore` seems to disable the workflow in all cases.
---
 .github/workflows/ci-browser.yml |  4 ++--
 .github/workflows/ci.yml         |  4 ++--
 package-lock.json                | 19 +++++++++----------
 packages/engine.io/package.json  |  2 +-
 4 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/ci-browser.yml b/.github/workflows/ci-browser.yml
index b9c49187fa..537d2a0c8d 100644
--- a/.github/workflows/ci-browser.yml
+++ b/.github/workflows/ci-browser.yml
@@ -2,13 +2,13 @@ name: CI (browser)
 
 on:
   push:
+    branches:
+      - '**'
     paths:
       - 'packages/engine.io-parser/**'
       - 'packages/engine.io-client/**'
       - 'packages/socket.io-parser/**'
       - 'packages/socket.io-client/**'
-    tags-ignore:
-      - '**@*'
 
 permissions:
   contents: read
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 07ac39eacc..ce37224d3e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -2,8 +2,8 @@ name: CI
 
 on:
   push:
-    tags-ignore:
-      - '**@*'
+    branches:
+      - '**'
   pull_request:
   schedule:
     - cron: '0 0 * * 0'
diff --git a/package-lock.json b/package-lock.json
index ec74abb37b..bffd06a5c6 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -5643,6 +5643,14 @@
       "integrity": "sha512-Kvp459HrV2FEJ1CAsi1Ku+MY3kasH19TFykTz2xWmMeq6bk2NU3XXvfJ+Q61m0xktWwt+1HSYf3JZsTms3aRJg==",
       "dev": true
     },
+    "node_modules/cookie": {
+      "version": "0.7.2",
+      "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.7.2.tgz",
+      "integrity": "sha512-yki5XnKuf750l50uGTllt6kKILY4nQ1eNIQatoXEByZ5dWgnKqbnqmTrBE5B4N7lrMJKQ2ytWMiTO2o0v6Ew/w==",
+      "engines": {
+        "node": ">= 0.6"
+      }
+    },
     "node_modules/cookie-signature": {
       "version": "1.0.6",
       "resolved": "https://registry.npmjs.org/cookie-signature/-/cookie-signature-1.0.6.tgz",
@@ -15162,7 +15170,7 @@
         "@types/node": ">=10.0.0",
         "accepts": "~1.3.4",
         "base64id": "2.0.0",
-        "cookie": "~0.7.0",
+        "cookie": "~0.7.2",
         "cors": "~2.8.5",
         "debug": "~4.3.1",
         "engine.io-parser": "~5.2.1",
@@ -15198,15 +15206,6 @@
         "node": ">=10.0.0"
       }
     },
-    "packages/engine.io/node_modules/cookie": {
-      "version": "0.7.2",
-      "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.7.2.tgz",
-      "integrity": "sha512-yki5XnKuf750l50uGTllt6kKILY4nQ1eNIQatoXEByZ5dWgnKqbnqmTrBE5B4N7lrMJKQ2ytWMiTO2o0v6Ew/w==",
-      "license": "MIT",
-      "engines": {
-        "node": ">= 0.6"
-      }
-    },
     "packages/engine.io/node_modules/debug": {
       "version": "4.3.3",
       "resolved": "https://registry.npmjs.org/debug/-/debug-4.3.3.tgz",
diff --git a/packages/engine.io/package.json b/packages/engine.io/package.json
index 887d44e860..e99e90a058 100644
--- a/packages/engine.io/package.json
+++ b/packages/engine.io/package.json
@@ -36,7 +36,7 @@
     "@types/node": ">=10.0.0",
     "accepts": "~1.3.4",
     "base64id": "2.0.0",
-    "cookie": "~0.7.0",
+    "cookie": "~0.7.2",
     "cors": "~2.8.5",
     "debug": "~4.3.1",
     "engine.io-parser": "~5.2.1",