diff --git a/.github/workflows/tests-mysql.yml b/.github/workflows/tests-mysql.yml
index 7c0659976013..47315858373c 100644
--- a/.github/workflows/tests-mysql.yml
+++ b/.github/workflows/tests-mysql.yml
@@ -43,7 +43,7 @@ jobs:
id: composer-cache
run: |
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
- - uses: actions/cache@v3
+ - uses: actions/cache@v4
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-${{ matrix.php-version }}-composer-${{ hashFiles('**/composer.lock') }}
diff --git a/.github/workflows/tests-sqlite.yml b/.github/workflows/tests-sqlite.yml
index 5b41c60deab4..405dc92134de 100644
--- a/.github/workflows/tests-sqlite.yml
+++ b/.github/workflows/tests-sqlite.yml
@@ -31,7 +31,7 @@ jobs:
id: composer-cache
run: |
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
- - uses: actions/cache@v3
+ - uses: actions/cache@v4
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-${{ matrix.php-version }}-composer-${{ hashFiles('**/composer.lock') }}
diff --git a/app/Console/Commands/LdapSync.php b/app/Console/Commands/LdapSync.php
index e861b9af37e4..05f60ee4e14d 100755
--- a/app/Console/Commands/LdapSync.php
+++ b/app/Console/Commands/LdapSync.php
@@ -88,18 +88,20 @@ public function handle()
/**
* if a location ID has been specified, use that OU
*/
- if ( $this->option('location_id') != '') {
+ if ( $this->option('location_id') ) {
foreach($this->option('location_id') as $location_id){
$location_ou = Location::where('id', '=', $location_id)->value('ldap_ou');
$search_base = $location_ou;
Log::debug('Importing users from specified location OU: \"'.$search_base.'\".');
}
+ }
/**
- * Otherwise if a manual base DN has been specified, use that
+ * if a manual base DN has been specified, use that. Allow the Base DN to override
+ * even if there's a location-based DN - if you picked it, you must have picked it for a reason.
*/
- } elseif ($this->option('base_dn') != '') {
+ if ($this->option('base_dn') != '') {
$search_base = $this->option('base_dn');
Log::debug('Importing users from specified base DN: \"'.$search_base.'\".');
}
@@ -125,14 +127,14 @@ public function handle()
/* Determine which location to assign users to by default. */
$location = null; // TODO - this would be better called "$default_location", which is more explicit about its purpose
- if ($this->option('location') != '') {
- if ($location = Location::where('name', '=', $this->option('location'))->first()) {
- Log::debug('Location name ' . $this->option('location') . ' passed');
- Log::debug('Importing to ' . $location->name . ' (' . $location->id . ')');
- }
+ if ($this->option('location') != '') {
+ if ($location = Location::where('name', '=', $this->option('location'))->first()) {
+ Log::debug('Location name ' . $this->option('location') . ' passed');
+ Log::debug('Importing to ' . $location->name . ' (' . $location->id . ')');
+ }
- } elseif ($this->option('location_id') != '') {
- foreach($this->option('location_id') as $location_id) {
+ } elseif ($this->option('location_id')) {
+ foreach($this->option('location_id') as $location_id) {
if ($location = Location::where('id', '=', $location_id)->first()) {
Log::debug('Location ID ' . $location_id . ' passed');
Log::debug('Importing to ' . $location->name . ' (' . $location->id . ')');
diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php
index 5c55376c8572..3e8afab401df 100644
--- a/app/Http/Controllers/ReportsController.php
+++ b/app/Http/Controllers/ReportsController.php
@@ -718,10 +718,10 @@ public function postCustom(CustomAssetReportRequest $request)
if ($request->filled('exclude_archived')) {
$assets->notArchived();
}
- if ($request->input('deleted_assets') == '1') {
+ if ($request->input('deleted_assets') == 'include_deleted') {
$assets->withTrashed();
}
- if ($request->input('deleted_assets') == '0') {
+ if ($request->input('deleted_assets') == 'only_deleted') {
$assets->onlyTrashed();
}
diff --git a/resources/lang/en-US/admin/manufacturers/message.php b/resources/lang/en-US/admin/manufacturers/message.php
index 87763584996b..61416e023026 100644
--- a/resources/lang/en-US/admin/manufacturers/message.php
+++ b/resources/lang/en-US/admin/manufacturers/message.php
@@ -2,7 +2,7 @@
return array(
- 'support_url_help' => 'Variables {LOCALE}
, {SERIAL}
, {MODEL_NUMBER}
, and {MODEL_NAME}
may be used in your URL to have those values auto-populate when viewing assets - for example https://support.apple.com/{LOCALE}/{SERIAL}.',
+ 'support_url_help' => 'Variables {LOCALE}
, {SERIAL}
, {MODEL_NUMBER}
, and {MODEL_NAME}
may be used in your URL to have those values auto-populate when viewing assets - for example https://checkcoverage.apple.com/{LOCALE}/{SERIAL}.',
'does_not_exist' => 'Manufacturer does not exist.',
'assoc_users' => 'This manufacturer is currently associated with at least one model and cannot be deleted. Please update your models to no longer reference this manufacturer and try again. ',
diff --git a/resources/views/reports/custom.blade.php b/resources/views/reports/custom.blade.php
index cc0ec158af39..0702f0332e48 100644
--- a/resources/views/reports/custom.blade.php
+++ b/resources/views/reports/custom.blade.php
@@ -434,15 +434,15 @@