You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for putting together the tutorial in the iPython notebook! While trying to use it, I came across the following bugs and suggested fixes:
from graphwave.shapes import build_graph should be from GraphWave.shapes import build_graph
from graphwave.graphwave import * should be from GraphWave.graphwave import *
in build_graph.py, from utils.utils import * should be from ...utils.utils import * - this is not best practice, but is a temporary bandaid for a breaking build path
np.random.seed(123) should be in the 2nd cell (not in the 1st) so that the 2nd cell can be rerun multiple times with the same result
chi, heat_print, taus=graphwave(G, taus='automatic', verbose=False) should be chi, heat_print, taus=graphwave_alg(G, time_pnts, taus='auto', verbose=False) - this is really a couple of things: function graphwave has been renamed to graphwave_alg (I think?), time_pnts argument should be provided (looks like the function signature has changed), and automatic should be auto
Can the author verify that these changes are in fact correct and update the 'Using GraphWave' notebook with the results that are expected?
The text was updated successfully, but these errors were encountered:
Thanks for putting together the tutorial in the iPython notebook! While trying to use it, I came across the following bugs and suggested fixes:
from graphwave.shapes import build_graph
should befrom GraphWave.shapes import build_graph
from graphwave.graphwave import *
should befrom GraphWave.graphwave import *
in
build_graph.py
,from utils.utils import *
should befrom ...utils.utils import *
- this is not best practice, but is a temporary bandaid for a breaking build pathnp.random.seed(123)
should be in the 2nd cell (not in the 1st) so that the 2nd cell can be rerun multiple times with the same resultchi, heat_print, taus=graphwave(G, taus='automatic', verbose=False)
should bechi, heat_print, taus=graphwave_alg(G, time_pnts, taus='auto', verbose=False)
- this is really a couple of things: functiongraphwave
has been renamed tographwave_alg
(I think?),time_pnts
argument should be provided (looks like the function signature has changed), andautomatic
should beauto
Can the author verify that these changes are in fact correct and update the 'Using GraphWave' notebook with the results that are expected?
The text was updated successfully, but these errors were encountered: