Update URLs for OEBB parser to use HTTPS + switch to XML queries (from HAFAS binary) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The website made https mandatory now. With the old http URLs the queries don't work any more.
Seems to work around the issue that connectionDetailsVersion in the binary data is now more modern than what Fahrplan currently supports.
soulsource
changed the title
|
I've implemented these changes at : https://github.com/poetaster/fahrplan/releases/tag/2.0.36 A review that I've done it correctly would be appreciated! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The website made https mandatory now. With the old http URLs the queries don't work any more.
Fixes #283
Edit:
Furthermore I recently got some connections of
connectionDetailsVersion != 1and couldn't find a source online on how to handle this issue. As a workaround the second commit in this PR changes ÖBB to use XML queries.