-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error message on backend "resrobot.se" station departures search #267
Comments
@mikwebdev Thank you for reporting this. I'll have a look at it ASAP. |
@f03el Thank you. Much appreciated as I still use Fahrplan on my Nokia N9 regularly. |
The reply from the server is just an empty JSON object (i.e. |
Yes, an empty result list is much better than an loading squircle and error message. With constant loading squircle and error message it gives the impression that something is technically wrong. Maybe change error message to something like "No departures found." or "No results found." and stop the loading squircle? I have attached an error message from rejseplanen.dk. Maybe do something similar? For example: |
OK, I think an empty result list is the only possible solution in this case. There is no way we can know whether the reply is empty just because there simply are no departures from that station at the time, or because the user has selected a "bad" combination of station and direction. If you want to test a bus stop with no departures, try "Granträskvägen (Lycksele kn)" in the weekend. :) The backend only has the options to either return a list of departures (special case: empty list), or throw an exception, which shows an error message (in the N9 case with a loading circle). The loading circle is nothing the backend controls. On Sailfish OS there is no indicator or similar in this case. It just shows the error message. |
Ok, I understand. I'm fine with an empty list, as long as loading squircle and error message doesn't show. |
Sometimes, the server reply can be empty and still valid. This is for example the case with time table replies when there are no departures from a station (or at least not any departures matching the selected direction). Fixes smurfy#267.
[Affected versions]:
[Affected platforms]:
[Steps to reproduce]:
[Expected result]:
[Actual result]:
[Notes]:
The text was updated successfully, but these errors were encountered: