FocusManager: error on refreshing container

[ItsAsbreuk]

Ryan,

I don't have time left to isolate the issue, so I hope it's reproducable...
I ran into this:

Gotta container with focusable-items, where I select one by focusManager.next().
Now, I refresh the container with new content (new focusable items)

I found out the console runs into continous erroring 'TypeError: node is null'
(node-core-debug.js line 347)

I think the error occurs because focusManager.next() calls nextItem.next(itemSelector);
Perhaps the definition inside YUI's internal nodelist is here defined and I ripped it away:

<div id='container'> <!-- has focusmanager plugged in -->
    <div id='insidecontainer'>
        <input type='text' value='1' /> <!-- focusable item -->
        <input type='text' value='2' /> <!-- focusable item -->
    </div>
</div>

insidecontainer.destroy(); // <-- removing this line will make the error disappear
insidecontainer.setHTML(newContent);

Thus, the error occurs when I manually call insidecontainer.destroy();
The error also does not appear when I focus by mouseclick. This made me think focusManager.next() had some code that interferred.

Regards,
Marco.

[ItsAsbreuk]

Just updated the errordescription

[ItsAsbreuk]

Hi Ryan,

I picked this up and traced the bug.
It happened when after an activeItemChange e.prevVal has a value, but the node is removed from the dom.

To resolve the issue, I made these changes:

_afterActiveItemChange: function (e) {
        var newVal  = e.newVal,
            prevVal = e.prevVal;

        if (prevVal && this.host.one('#'+prevVal._yuid)) {
            prevVal.set('tabIndex', -1);
        }

        if (newVal) {
            newVal.set('tabIndex', 0);

            if (this.get('focused')) {
                newVal.focus();
            }
        }
    },

Regards,
Marco

[rgrove]

Thanks! I'll tackle this as soon as I get back to working on FocusManager.

[ItsAsbreuk]

All right.

I think I was too ambigious in the proposed fix.
I am using this code now myself:

    _afterActiveItemChange: function (e) {
        var newVal  = e.newVal,
            prevVal = e.prevVal;

        if (Y.one(prevVal)) {
            prevVal.set('tabIndex', -1);
        }
        if (newVal) {
            newVal.set('tabIndex', 0);
            if (this.get('focused')) {
                newVal.focus();
            }
        }
    },

Marco