Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in gaps in identification code testing #523

Open
acesnik opened this issue Sep 7, 2018 · 1 comment
Open

Fill in gaps in identification code testing #523

acesnik opened this issue Sep 7, 2018 · 1 comment
Labels

Comments

@acesnik
Copy link
Collaborator

acesnik commented Sep 7, 2018

There are a few gaps in the identification code testing that are actually pretty pertinent to these changes in Modification.

e.g. https://codecov.io/gh/smith-chem-wisc/ProteoformSuite/src/ca455bbdadd0d5bc58a7ddfde977014b797b957e/ProteoformSuiteInternal/Proteoform.cs#L211

@acesnik acesnik added the Testing label Sep 7, 2018
@leahvschaffer
Copy link
Member

That link isn't working for me do you mind showing me what lines are uncovered?

Also I think we should consider getting Jenkins working for PS too for stuff like this. Maybe Sheeren would have time after the WPF stuff is done. A bandaid might be to do a full run unit test and the values should all match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants