Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lollipop fields -> properties #496

Open
acesnik opened this issue Feb 27, 2018 · 0 comments
Open

Lollipop fields -> properties #496

acesnik opened this issue Feb 27, 2018 · 0 comments
Labels
Code Quality

Comments

@acesnik
Copy link
Collaborator

acesnik commented Feb 27, 2018

Apparently, all of our public fields in Lollipop are recommended by Codacy to be public properties instead. Something about fields not being part of the API ...

If we make that change, watch out for the methods in Sweet.add_settings and Sweet.open_method, which assume that the important Lollipop parameters are specified in Fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acesnik