Added check for active OAuth to login route #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we reuse the Update: Furthermore, we can introduce an option to disable LDAP login, given that OAuth2 authentication operates independently. Consequently, this PR does not require the inclusion of a new option. |
|
I prefer to introduce a new option Additionally, disabling the login page may result in an infinite redirection loop. If OAuth login fails, we redirect to the |
smhaller
added a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to directly skip the login page when OAuth is enabled.
If needed, there could be a variable to enable this, although I don't see the value since adding the OAuth provider broke the regular login for me anyway.
Fixes #42 .