Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid / broken user settings links when using oauth2 logins #39

Open
2 tasks
mooomooo opened this issue Dec 6, 2023 · 4 comments
Open
2 tasks

Invalid / broken user settings links when using oauth2 logins #39

mooomooo opened this issue Dec 6, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@mooomooo
Copy link

mooomooo commented Dec 6, 2023

  • The "delete your account" link does nothing but link back to the user settings page.
  • Trying to "request password reset" fails, showing "Something went wrong. Please try again."
@smhaller
Copy link
Owner

smhaller commented Dec 6, 2023

I think those two user settings can be removed for the moment:

  • Password reset should be done within the OAUTH Provider Service
  • I am not sure what should happen on delete

What do you think?

@mooomooo
Copy link
Author

mooomooo commented Dec 6, 2023

Agreed on removing the password reset option.

I think delete could still be allowable, for when a user wants to leave the overleaf service / clear their data, but not deregister from the oauth2 provider. But it's also fine to remove that option, especially if there's a pathway for an admin to delete user data.

@yzx9
Copy link
Collaborator

yzx9 commented Dec 7, 2023

I don't quite understand why we previously disabled the 'delete your account' and 'request password reset' options. Is it because of the ALLOW_EMAIL_LOGIN option?

@smhaller
Copy link
Owner

smhaller commented Dec 7, 2023

  • The password reset is working with the current version using LDAP Authentication (and it was enabled till 3.3.2. - then i did not check it)
  • I never used delete in my setup so I cannot say anything about that

@yzx9 yzx9 added the bug Something isn't working label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants