Skip to content
This repository has been archived by the owner on Feb 14, 2019. It is now read-only.

top #379

Open
hezedu opened this issue Mar 17, 2015 · 17 comments
Open

top #379

hezedu opened this issue Mar 17, 2015 · 17 comments

Comments

@hezedu
Copy link

hezedu commented Mar 17, 2015

506 line : top=top+document.body.scrollTop
is a bug.

delete it

@lvshin
Copy link

lvshin commented Jul 24, 2015

I have found the same bug today.
Is this project still alive?

@AuspeXeu
Copy link
Collaborator

Describe why it is a bug. What behaviour can you observe?

@Aleksandern
Copy link

You can see this bug on a mobile device...see attached file...
bug_datetimepicker

@AuspeXeu
Copy link
Collaborator

Which device/browser and do you have the link to the website for me?

@Aleksandern
Copy link

Android Opera... You can also use Chrome DevTools device mode (https://developers.google.com/web/tools/setup/device-testing/devtools-emulator), just select Google Nexus 5...
Your demo pages doesn't have this bug...

Unfortunately I can't provide a link. However, I can create a new page if you can't catch this bug.

@AuspeXeu
Copy link
Collaborator

Well that's hard to grasp then if I cannot reproduce :D

@Aleksandern
Copy link

Ok. Give me some time please

@AuspeXeu
Copy link
Collaborator

Sure thing 👍

@Aleksandern
Copy link

scroll to bottom of the page... after that click "Start date" or "End date"

http://.../pages/index.html

@AuspeXeu
Copy link
Collaborator

Okay. This seems to be buggy in Chrome but works perfectly fine in firefox. Can you patch the website so that it works in chrome by using this comment? 506 line : top=top+document.body.scrollTop

@Aleksandern
Copy link

I've commented 537 line

if( !elementOrParentIsFixed(this.element) ){
//top = top + document.body.scrollTop;
}

@AuspeXeu
Copy link
Collaborator

And then it seems to work on mobile + chrome + firefox. Can you confirm that?

@Aleksandern
Copy link

Yes I confirm that.

@AuspeXeu
Copy link
Collaborator

Mind filing a pull request for this fix?

@Aleksandern
Copy link

You mean I need to create a pull request?

@AuspeXeu
Copy link
Collaborator

Yes please

This was referenced Sep 18, 2015
@jarstelfox
Copy link

Will be resolved in PR #645, see commit edadb5b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants