Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonbProperty#nillable attribute is replaced by @JsonbNillable #2253

Open
t1 opened this issue Dec 21, 2024 · 6 comments · May be fixed by #2254
Open

JsonbProperty#nillable attribute is replaced by @JsonbNillable #2253

t1 opened this issue Dec 21, 2024 · 6 comments · May be fixed by #2254
Labels
Client This issue applies to the Client side good first issue Good for newcomers

Comments

@t1
Copy link
Collaborator

t1 commented Dec 21, 2024

          I just saw that the `nillable = true` attribute is replaced by `@JsonbNillable`

See: https://jakarta.ee/specifications/jsonb/3.0/apidocs/jakarta.json.bind/jakarta/json/bind/annotation/jsonbproperty#nillable()

So I guess a follow up issue/PR to fix FieldInfo is needed.

Originally posted by @jmini in #2251 (comment)

@t1 t1 added good first issue Good for newcomers Client This issue applies to the Client side labels Dec 21, 2024
@t1
Copy link
Collaborator Author

t1 commented Dec 21, 2024

@jmartisk: I currently experience maven build problems, because some versions seem to be missing. Are you aware or am I doing something wrong?

@t1
Copy link
Collaborator Author

t1 commented Dec 21, 2024

Oh, and by the way: the example code in custom-json-serializers-deserializers should be fixed, too.

@jmartisk
Copy link
Member

jmartisk commented Dec 23, 2024

@jmartisk: I currently experience maven build problems, because some versions seem to be missing. Are you aware or am I doing something wrong?

You're talking about 2.12.0 right? What exactly is missing? I know there was an issue with the Gradle plugin, I had to deploy it manually afterwards

jmini added a commit to jmini/smallrye-graphql that referenced this issue Dec 30, 2024
@jmini jmini linked a pull request Dec 30, 2024 that will close this issue
@jmini
Copy link
Contributor

jmini commented Dec 30, 2024

@t1 I have opened this PR #2254 for support for @JsonbNillable, but I am not really sure this is enough and I wanted to contribute a test case (and I do not see how to add it)

@jmini
Copy link
Contributor

jmini commented Dec 30, 2024

Oh, and by the way: the example code in custom-json-serializers-deserializers should be fixed, too.

This is why docs written with asciidoctor with code snippets included from a test class that is compiled and executed at built time helps to keep the doc up-to-date.

I did not worked on that part

@jmartisk
Copy link
Member

jmartisk commented Jan 2, 2025

Oh, and by the way: the example code in custom-json-serializers-deserializers should be fixed, too.

This is why docs written with asciidoctor with code snippets included from a test class that is compiled and executed at built time helps to keep the doc up-to-date.

It's a double-edged sword because it also complicates the build quite a bit by adding new dependencies between modules (affecting the release process), and it could lead to unexpected surprises when you change some code and don't realize that it could break the docs. I'm personally not a big fan of this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue applies to the Client side good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants