Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to better understand the workflow around asking for new features #49

Open
philiph-slac opened this issue Mar 15, 2024 · 1 comment

Comments

@philiph-slac
Copy link
Collaborator

Are we to use issues? That doesn't seem to have been the case so far. I thought we did a pull request but I'm told that's not the usual style or my question is badly posed. I think TID uses JIRA for this not a git native procedure.

At the moment I want to add the idea of handling the saturation setting in LinearityPlotsParallelSlice - it should turn off when we're in AHL or AML and on otherwise. But the script doesn't entirely obviously know what gain configuration as it stands. This could be extracted from the data config or a command line specification (which would be a bit of a pain to do every time).

@nstelter-slac
Copy link
Collaborator

nstelter-slac commented Mar 16, 2024

Hi,

I'm in favor of using issues.

The benefit is it keeps everything easy to find on this one GitHub page, its integrated into the repo (can nicely link to parts of the code base, etc), and can also link an issue to a code patch. Issues can be auto-closed when the related patch is merged in.

So I'd say feel free to open up more issues with anything that needs to be done/added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants