Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] When using the rename shortcut key N, there is a probability to enter it #1440

Closed
AdminHcat opened this issue Apr 7, 2022 · 2 comments
Closed

[gui] When using the rename shortcut key N, there is a probability to enter it #1440

AdminHcat opened this issue Apr 7, 2022 · 2 comments
Labels
bug GUI Issues in jadx-gui module
Milestone
TBD

Comments

@AdminHcat
Copy link

When using the rename shortcut key N, there is a probability to enter it

There have been many times. When you press the N key, n appears instead of the original name

The following is the keyboard test software, indicating that the keyboard is pressed only once
image
@skylot
Copy link
Owner

skylot commented Apr 7, 2022

@AdminHcat thanks! I also notice this issue, and I agree, it is annoying.
I will try harder to fix this because my previous attempts not succeed, and I still don't understand the cause 🙁

@skylot skylot added bug GUI Issues in jadx-gui module labels Apr 7, 2022
@skylot skylot added this to the TBD milestone Apr 7, 2022
iscle added a commit to iscle/jadx that referenced this issue Dec 31, 2023
@iscle
fix: attempt to improve field rename issues with "n" shortcut
5f53650 
This is an attempt to fix the issues that sometimes arise when renaming functions or variables using the "n" shortcut as stated in issue skylot#1440.

The reasoning behind the change: The instance creation of the RenameDialog was somehow affecting the UI thread and not allowing for the key release event to be dispatched. By running everything inside the invokeLater block, this might get fixed as it will execute after all previous tasks are finished.
We now also only show the dialog after EVERYTHING is set up, not before.
@iscle iscle mentioned this issue Dec 31, 2023
Merged
skylot pushed a commit that referenced this issue Jan 5, 2024
@iscle
fix(gui): attempt to resolve field rename issues with shortcut (#1440)…
23e643c 
…(PR#2075)

This is an attempt to fix the issues that sometimes arise when renaming functions or variables using the "n" shortcut as stated in issue #1440.

The reasoning behind the change: The instance creation of the RenameDialog was somehow affecting the UI thread and not allowing for the key release event to be dispatched. By running everything inside the invokeLater block, this might get fixed as it will execute after all previous tasks are finished.
We now also only show the dialog after EVERYTHING is set up, not before.
@skylot
Copy link
Owner

skylot commented Jan 5, 2024

Fixed in PR #2075

@skylot skylot closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug GUI Issues in jadx-gui module
Projects
None yet
Milestone
TBD
Development

No branches or pull requests
2 participants
@skylot @AdminHcat