-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving docs, examples, and tutorials of pytorch-forecasting
#1718
Comments
@fkiraly FYI |
also, I need to figure out what |
Hi, I just saw this issue. I just created PR #1720 on I think that is probably connected. |
@yarnabrina, @benHeid Any thoughts on above suggestions? I would like your input if possible :) |
I fully agree with your general step by step tutorial idea. The current one does not seem approachable for beginners. I think in pydata I tried to start with just endogenous single series, then adding panel/hierarchy part, followed by hierarchy, then exogenous, etc. type of flow, so if you can also do that type of flow with pytorch-forecasting, that'll be great. As a first tutorial, I will probably not vary hyperparameters too much, but use the most common ones in the first case, and try to keep them similar in following steps if it make sense. Another thing that comes to my mind is I'll probably prefer to isolate the tuning part from usage without tuning part, because in my opinion it helps to get started with fit->predict flow common in most libraries first. These are of course just suggestions from my side, please feel free to adjust as you deem better. In sktime we have the option to tell user how to check if all models are applicable for a section or not using tags, I think that's missing here. In future, adding a functionality for that may be useful. I'll not make a comment about change of |
I agree that we should do this, and I also agree to the comment of @yarnabrina. 1_introduction_to_pytorch_forecasting |
This list is a quick bucket list of items that can be potentially improved from what I've seen in the docs.
As requested by @yarnabrina, we should create simple examples, reducing complexity of the library as much as possible, to encourage users who are not too familiar with
pytorch-forecasting
or time series machine learning in general to try out the library. I think for example, the 'Example' inside https://pytorch-forecasting.readthedocs.io/en/stable/getting-started.html# is way too complicated, and will deter users from using the library because it is too complex to understand and read through as a first time user.Thus for now, I'm proposing we
I think these two items can improved in the following way:
TimeSeriesDataset
, differentModel
s,Trainers
, etc), but with little to no explanations. This basic tutorial is designed to essentially be a minimal walkthrough on how to use the library. The preceding tutorials will explain more in depth about each module. For example, we will have one tutorial explainingTimeSeriesDataset
and so on.I am also proposing that we split the directory that is used to load the data into a new directory inside the root folder named
datasets
. This folder will be the primarily method to load datasets for tutorials or for modelling purposes. To reduce duplication, we can just import loading methods from the sktime library.This will allow us to keep the examples directory standalone, and the files inside will be used to code up simple functions and variables that can be used inside tutorials.
The text was updated successfully, but these errors were encountered: