Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion Content Shift in Safari #1007

Closed
niktek opened this issue Feb 21, 2023 · 2 comments
Closed

Accordion Content Shift in Safari #1007

niktek opened this issue Feb 21, 2023 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@niktek
Copy link
Contributor

niktek commented Feb 21, 2023

Current Behavior

When opening an AccordionItem in Safari the content underneath shifts up and down a bit at the end of the animation

Steps To Reproduce

No response

Anything else?

No response

@niktek niktek added the bug Something isn't working label Feb 21, 2023
@endigo9740 endigo9740 added this to the v1.0 milestone Feb 24, 2023
@endigo9740
Copy link
Contributor

@niktek I took a look at this, I can recreate the issue (the wobble) but I feel this may reside on Svelte's end:
sveltejs/svelte#4712

Another way I found it useful to do this on safari (without adding css property) is don't use built-in slide function with transition directive in Safari since it uses css animation. Safari has a bug that it'll ignore element overflow: hidden when element is transitioning.

They mention a work around later in that thread, and even that it was fixed in a release. But nothing I've thrown at this seems to help. I'm going to mark this "help wanted" in case anyone else wants to take a look.

@endigo9740 endigo9740 added the help wanted Extra attention is needed label Feb 28, 2023
@endigo9740 endigo9740 modified the milestones: v1.0, Future/Whenever Feb 28, 2023
@endigo9740
Copy link
Contributor

I'm going to say for now this is something we cannot actually solve on our end. I feel the fault lies within Svelte transition slide and Safari. I might suggest reporting this upstream if you get a chance @niktek

@endigo9740 endigo9740 added wontfix This will not be worked on and removed help wanted Extra attention is needed labels Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants