Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deny multiple mails per fingerprint #13

Closed
3 tasks
skariel opened this issue Dec 26, 2024 · 3 comments
Closed
3 tasks

deny multiple mails per fingerprint #13

skariel opened this issue Dec 26, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@skariel
Copy link
Owner

skariel commented Dec 26, 2024

This is problematic because:

  1. Mail is an "identity", just like a github user name is. Having multiple mails, or multiple github user names per fingerprint would cause identity confusion -- a single key would represent multiple identities, which goes against the principle of clear identity mapping that the service provides. This could complicate the trust model.
  2. Privacy Issues: When someone looks up a key, which email should be returned? This complicates the get email command and permission system.

Is there a specific usecase for multiple mails per fingerprint?

Path to solution:

  • mark fingerprints as unique in schema
  • verify in handleregister
  • remove duplicates and send notification mail
@skariel skariel added the bug Something isn't working label Dec 26, 2024
@skariel skariel self-assigned this Dec 26, 2024
@skariel skariel mentioned this issue Dec 26, 2024
@sebbu2
Copy link

sebbu2 commented Dec 27, 2024

I have multiple mails and (gpg and ssh, 2 of each) keys on my github username.
Thoses 2 gpg keys each have multiple email associated.

For 2, it could just return all of them.
For 1... I can hide my email on github / gitlab, so each would generate me a private email, but i use the same key on both.

@skariel
Copy link
Owner Author

skariel commented Dec 27, 2024

ok, this is a fair usecase. I'm closing this issue and opening a new one #14 (support multiple mails per key). initially will be treated as a signle entity, more granularity can be added as needed

@skariel skariel closed this as completed Dec 27, 2024
@skariel
Copy link
Owner Author

skariel commented Jan 6, 2025

hi an update: I started implementing this, and noticed that having multiple fingerprints per mail and multiple mails per fingerprint results in a graph, and checking for permissions now requires a connected component analysis.

so I intend to implement it. however due to the complexity my plan is to first finish writing some tests, and then moving to sqlc, then doing some schema refactoring, and finally implementing this feature. so it may take some time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants