Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oversized return value for get_action #5

Open
rlipkis opened this issue Jan 14, 2021 · 0 comments
Open

Oversized return value for get_action #5

rlipkis opened this issue Jan 14, 2021 · 0 comments

Comments

@rlipkis
Copy link

rlipkis commented Jan 14, 2021

The function get_action (for the DRL solvers) returns rand(distribution, policy.solver.action_size), but since distribution is already multivariate, this allocates and fills a square matrix with samples (of which only the first is relevant / used) -- I think the intended return value is rand(distribution). I can submit a pull request if that's preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant