Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File size and frame rate defaults #28

Closed
kornelski opened this issue Mar 17, 2018 · 6 comments · Fixed by #31
Closed

File size and frame rate defaults #28

kornelski opened this issue Mar 17, 2018 · 6 comments · Fixed by #31

Comments

@kornelski
Copy link
Collaborator

To avoid creating huge/wasteful GIFs, I suggest having smart defaults.

  • If resolution is >= 640px wide, halve it. Videos have chroma subsampling and compression artefacts that are wasteful in GIF, so halving resolution for GIF is a good idea anyway.
  • If framerate is >= 24fps, halve it. Frames cost a lot in GIF.
@sindresorhus
Copy link
Owner

sindresorhus commented Mar 17, 2018

What do you mean by "halve it"? People expect to get the resolution/fps they chose.

@kornelski
Copy link
Collaborator Author

kornelski commented Mar 17, 2018

I mean setting sliders in the UI to that value when the window is opened.

Instead of defaulting values set in the UI to values read directly from the video (effectively max resolution, max fps by default), default to values from the video adjusted to make more sense.

@sindresorhus
Copy link
Owner

Ah ok. Yes, I agree.

@LarsJK
Copy link
Contributor

LarsJK commented Mar 19, 2018

I added a fix for this.

However the scale slider has a minimum value of 0.2. Should I do something about this?

If I record a fullscreen recording it will be 3360 × 2100 which means I can't make a gif smaller than 672 x 420.

@LarsJK
Copy link
Contributor

LarsJK commented Mar 19, 2018

Maybe define a minimum dimension and set the minimum scale dynamically based on that..?

@kornelski
Copy link
Collaborator Author

I've made suggestion for the dimensions here #25 (comment)

sindresorhus pushed a commit that referenced this issue Jun 12, 2018
We already clamp the framerate to 5-30. Do wee need to also halve it? If so should the halving be based on the clamped value, or the original value then clamped to 5-30..?

closes #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants