-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File size and frame rate defaults #28
Comments
What do you mean by "halve it"? People expect to get the resolution/fps they chose. |
I mean setting sliders in the UI to that value when the window is opened. Instead of defaulting values set in the UI to values read directly from the video (effectively max resolution, max fps by default), default to values from the video adjusted to make more sense. |
Ah ok. Yes, I agree. |
I added a fix for this. However the scale slider has a minimum value of 0.2. Should I do something about this? If I record a fullscreen recording it will be 3360 × 2100 which means I can't make a gif smaller than 672 x 420. |
Maybe define a minimum dimension and set the minimum scale dynamically based on that..? |
I've made suggestion for the dimensions here #25 (comment) |
We already clamp the framerate to 5-30. Do wee need to also halve it? If so should the halving be based on the clamped value, or the original value then clamped to 5-30..? closes #28
To avoid creating huge/wasteful GIFs, I suggest having smart defaults.
The text was updated successfully, but these errors were encountered: