Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warning if the number of frames are too low #212

Open
sindresorhus opened this issue Oct 24, 2020 · 1 comment
Open

Show warning if the number of frames are too low #212

sindresorhus opened this issue Oct 24, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sindresorhus
Copy link
Owner

Gifski requires at least 2 frames in the resulting GIF, but users might accidentally trim or choose low enough FPS for the resulting GIF to contain less than 2 frames. We should show a warning in the editor's view in that case.

Right now, we just show an error when the conversion starts:

Screen Shot 2020-10-24 at 16 53 31
@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Oct 24, 2020
@sindresorhus sindresorhus added the good first issue Good for newcomers label Nov 25, 2020
@31aditya0193
Copy link

Hey @sindresorhus
is this still on todo list?
any UI direction where this warning should go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @31aditya0193