design review

[gkasprow]

• the power detector thresholds are free floating: DET_TRH_REV; DET_TRH_FWD; maybe add another MAX DAC
• the JK flip flop RSTn and CLK are shorted together on top entity which don't make much sense to me
• don't we need some manual reset button?
• won't T4 saturate due to slight output current imbalance?
• add LEDs: overtemp, FWD interlock, REV interlock; power good, P12V, P48V
• missing P3V3_CPCIS source
• there are a lot ERC and DRC errors
• add connector labels: EEM, fan
• add power rail LEDs and testpoints; possibly all in same PCB region, look at KASLI-DIOT
• don't we need more vias under exposed copper? It's gonna make RF cages with outer shield/heatsink
• be careful with such pads; we can make panel cutout as we do in other designs
  
• milling cuts bottom layer
  
• copper cannot touch board edge - make 0.5mm clearance
• missing proper DIOT ESD strip and resistors - copy it from Kasli-DIOT
• [ ]

[shanasz]

won't T4 saturate due to slight output current imbalance?

Core has Isat at least 7A, max current in Id of MRF101 in this application will be lower than 1A.

[gkasprow]

• please add trimpots to adjust bias during board tests

[gkasprow]

• Move the fine-tune input to the front panel, as in other designs like WENZEL_REF
• Make the reset button available from the front panel; use ordinary PB_TYCO_1-1825027-1
  
• Make sure the RF connectors are positioned as in newest Urukul - we want to re-use plastic distances
• Please add 3D model of the 6HP front panel (from Wenzel for example)
• please add 3D model of heatsink/shield
• when adding series resistor to the ADC input, remember about storage capacitor (10nF or so) to the ground at the ADC input.
  
• FIN1028 has failsafe feature - with inputs unconnected, it will produce 3.3V at the output holeind DET_RST permanently high. Add P-MOSFET in parallel to PB3 or inverter (like IC29)
• Where the power supply of IC29 is defined (VCC net) ? Add note on the schematic.
• put info about RF transformer ratios on the schematic
• IC33 will oscillate with ceramic caps, use 1..22u tantalum ones or add 100mOhm in series with C104

[shanasz]

IC33 will oscillate with ceramic caps, use 1..22u tantalum ones or add 100mOhm in series with C104

Changed to LT1117

[shanasz]

• correct ordered part list
• check debug connectors / testpoints for all test scenarios
• send 3D model changes (wider cave for tune connector and reset button)

[shanasz]

• correct PD placement