Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't duplicate stdout and stderr in verbose progress output #345

Closed
rmunn opened this issue Aug 14, 2024 · 0 comments · Fixed by #347
Closed

Don't duplicate stdout and stderr in verbose progress output #345

rmunn opened this issue Aug 14, 2024 · 0 comments · Fixed by #347
Assignees

Comments

@rmunn
Copy link
Contributor

rmunn commented Aug 14, 2024

HgRepository.GetTextFromQuery calls ExecuteErrorsOk, then prints the contents of stdout and stderr via progress.WriteVerbose if they aren't empty. However, ExecuteErrorsOk also prints stdout and stderr with progress.WriteVerbose if they aren't empty. This duplication does nothing but make it harder to find things in the Chorus output, and I suggest getting rid of the progress.WriteVerbose calls from HgRepository.GetTextFromQuery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant