Skip to content
This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

dbManager should use typed exceptions #30

Open
Ext3h opened this issue Sep 1, 2015 · 0 comments
Open

dbManager should use typed exceptions #30

Ext3h opened this issue Sep 1, 2015 · 0 comments

Comments

@Ext3h
Copy link
Contributor

Ext3h commented Sep 1, 2015

Right now, dbManager is throwing exceptions of basic type "Exception" to handle empty result sets and every context calling one of these functions is catching all exceptions as well.

This results in also catching actually fatal errors such as MySQL syntax errors and alike. This results in Codeface silently ignoring fatal runtime errors.

dbManager should use a custom exception type for empty result sets instead. All locations expecting exceptions must be changed as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant