-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drawing Tool - Insert image Icon no loaded from folders #307
Comments
Hey there, any news about this? Am I the unique person having this issue? |
Sorry for the late reply! I can't reproduce it, which distro are you using? |
No problem I know that we all are busy. I'm using Ubuntu 20.04.2 LTS . BTW, this information was already into the log that I wrote into the description. 😊 Thanks for getting back. I appreciate a lot you support. Have a nice weekend! |
Perhaps you want me to launch the app with specific parameters to trigger a special kind of logging trace? |
The only explanation I can think of: Do you possibly use the snap package? If so, please try the PPA: https://www.linuxuprising.com/2018/10/shutter-removed-from-ubuntu-1810-and.html |
Oh, nice try but I'm already using the PPA version from (Shutter 0.94.3 Rev.1306): |
What about version 0.95 (download at https://github.com/shutter-project/shutter/releases/tag/v0.95, unpack and launch bin/shutter in the unpacked folder)? |
I make that steps:
Should I install the "Number::Bytes::Human module"? |
Ah, right, my bad -- I forgot that version 0.95 has some new dependencies... Maybe we start with version 0.94.3 "installed" locally, just to exclude packaging problems: https://launchpad.net/shutter/+download Version 0.95 would need libnumber-bytes-human-perl and libglib-object-introspection-perl as new dependencies. |
Maybe @DarthGandalf can tell what is going on here as he is the only one among us who dealt with the Shutter code. 😄 |
I wish. I'm not that familiar with this code. @sWoRm can you try adding some |
I've defined 4 print:
This is the result:
May I do something else to help? Thank you for your support! |
You can put some additional prints around the |
I have added:
the results:
Perhaps we can create a branch where you could put as many prints as you need? Thanks 😃 |
Looks like activate signal (https://github.com/shutter-project/shutter/blob/master/share/shutter/resources/modules/Shutter/Draw/DrawingTool.pm#L6412) is never called, no idea why. |
During capturing this log, did you open the drawing tool and put mouse over the directory submenu? That's the moment when it reads the directory. |
Since it works on other distros maybe we should see which libs are involved and compare their versions between Ubuntu and, say, Arch or the distro you are using, @DarthGandalf? |
Yes, I put the mouse over, you can see it in the previous screenshots where I expand the menu. |
No, import from session is a different code path, and it's not in the activate callback |
Oh, you are right 🤓 |
I have no clue of Perl, Sorry If I'm saying a big mistake 🙏 Changing the signal from 'activate' to 'show' seems to do the trick. Which signal name should be the correct one? |
https://developer.gnome.org/gtk3/stable/GtkMenuItem.html#GtkMenuItem-activate is probably a better docs than the pygtk one which you found. Anyway, according to it,
I wonder what's wrong with |
I see on your screenshot that you managed to add another menu item there. I say your perl is fine :) |
And it wasn't 😅 |
Thank you @DarthGandalf for the link to clean documentation. As far as I understand, I agree that the Do you know If GTK has a demo to check that event/signal against widgets ? Some more detail about the differences between active and show: Please have a look at the screenshot.
To be coherent, I'm taking the test on the version: |
I've just create the PR from the unique branch: #313 |
Yeah, I haven't noticed it on my system, but it's the same.
I think this is some kind of race: Just to check whether your gtk2 installation is broken somehow: can you try the gtk3 branch from #284 ? It will need several new dependencies though (all should be available from apt). |
How exactly did you run my branch? That screenshot looks wrong |
Doing: How can I installed libgtk3-imageview-perl in ubuntu ?? I found a version for Ubuntu 21.04 not my version 20.04: http://manpages.ubuntu.com/manpages/hirsute/man3/Gtk3::ImageView.3pm.html |
Try
GooCanvas2::CairoTypes is also not available in ubuntu yet, which is why installing it from cpan |
Something for me to package for the AUR as well, I guess? |
I executed all the commands. But execute shutter _I got:
|
Do you want the log result? |
Does it show the images there? |
Shutter is no running:
|
cpanm -n -l ~/perl5 GooCanvas2::CairoTypes |
|
sudo apt install libgoocanvas-2.0-dev then try again |
Cool! |
Yes, perhaps it's something related to the gtk2 installation. I would like to understand. As you suggested, I will modify the PPA installed code with the I really love Shutter I use it for soo many years... I will wait then. Thanks for your support. Best regards 🤗 |
#284 is in, so closing |
Brief summary of issue
I'm facing a curious case.
When editing a picture with the Drawing Tool and try to insert an image icon from the button located at the bottom of the window, the folders: Cursor, Forms, and Tango Icon Library show the message: No icon was found
I had a small look at the code:
https://github.com/shutter-project/shutter/blob/master/share/shutter/resources/modules/Shutter/Draw/DrawingTool.pm#L530
https://github.com/shutter-project/shutter/blob/master/share/shutter/resources/modules/Shutter/Draw/DrawingTool.pm#L6365
to understand where those folders are located, It seems to be located on my system at:
/usr/share/shutter/resources/icons/drawing_tool/objects
BTW if I understand the code a little bit the structure of the folder shown in the button is created reading the folders into the disk.
Perhaps the folders are accessible to read but not the files?
Anyone can help/lead me to solve that?
Thanks a lot!
Steps to reproduce the issue
Shutter_Drawingtool_Folder_Empty_2021:
disk_folder_list:
Error output
No error output is seen apparently
Extra information, such as Shutter version, operating system and ideas for how to solve:
This is the output of the console:
The text was updated successfully, but these errors were encountered: