Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using local contexts instead of redux store for states which are not really used by different parts of the app #186

Open
acelaya opened this issue Jan 1, 2024 · 0 comments
Labels
enhancement New feature or request thech-debt

Comments

@acelaya
Copy link
Member

acelaya commented Jan 1, 2024

There are some pieces of state that are currently handled by redux store, which are not actually benefiting from it, but they suffer from the extra boilerplate of defining reducers and such.

For some states it does make sense to use redux, like tags, domains, and even the short URLs list.

On the other hand, visits and visits comparisons are always loaded when the corresponding section is opened, and it's hard to reuse due to all the filtering, batching and such.

For those, maybe using RTK query and sharing the result down the component tree via simple context might be easier to reason about.

@acelaya acelaya added enhancement New feature or request thech-debt labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request thech-debt
Projects
None yet
Development

No branches or pull requests

1 participant