Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to create users that never get cleaned up #32

Open
dewiniaid opened this issue Mar 20, 2016 · 2 comments
Open

Possible to create users that never get cleaned up #32

dewiniaid opened this issue Mar 20, 2016 · 2 comments

Comments

@dewiniaid
Copy link

Currently, members of self.users are primarily only destroyed when Pydle or the user in question leaves a channel. However, there are numerous events that call _sync_user, which will create the user in question if they don't already exist -- including receiving a NOTICE or PRIVMSG from another user.

Since these users are not necessarily in the same channel, Pydle will never see them leaving the channel and thus never know to clean them up. This can cause the users dict to become bloated over time.

@shizmob
Copy link
Owner

shizmob commented Apr 20, 2016

(Also didn't receive this one over email. Odd.)

Yeah, I'm aware of this, but currently not sure of a good method to fix this. Maybe a timed WHOIS or MONITOR for servers that support it.

@dewiniaid
Copy link
Author

I think my hackish workaround checks to see if the user I'm question shares channels with us at the end of one of the relevant methods, and -- if not -- destroys them. I'll see if I'm functional enough to dig out the source when I get home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants