Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

想要修改的地方, 如果有人看的话... #1

Open
shiyangzhaoa opened this issue Nov 22, 2019 · 4 comments
Open

想要修改的地方, 如果有人看的话... #1

shiyangzhaoa opened this issue Nov 22, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@shiyangzhaoa
Copy link
Owner

  • 很蠢的设计, 刚开始的截图是通过canvas设计的, 完全可以用 background-position 解决

  • 马赛克的实现需要重构

  • 代码逻辑重写, 目前的代码很乱

@shiyangzhaoa shiyangzhaoa added the enhancement New feature or request label Nov 22, 2019
@LsignQian
Copy link

🙏感谢呀……正在用您的组件,请问能加一个参数吗?最近发现工具栏上的叉没法直接退出截图有点苦恼怎么改

@shiyangzhaoa
Copy link
Owner Author

shiyangzhaoa commented Dec 3, 2019

@LsignQian 我晚点加个onClose, 如果你不传的话, 还是当前的行为, 如果你传个函数, 点击 X 的时候会触发这个函数, 参数是 默认的close 方法, 可以通过这个控制组件的隐藏

@shiyangzhaoa
Copy link
Owner Author

shiyangzhaoa commented Dec 4, 2019

@LsignQian 版本 0.1.4-beta, 提供了onClose, 大概下面这样

const handleClose = close => {
  alert('啊, 点击 X 了');
  close();
};

<ImageEditor onClose={handleClose} />

@LsignQian
Copy link

@LsignQian 版本 0.1.4-beta, 提供了onClose, 大概下面这样

const handleClose = close => {
  alert('啊, 点击 X 了');
  close();
};

<ImageEditor onClose={handleClose} />

啊!!!太感谢了!!!!!!!!!!!!!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants