-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support php-version: preinstalled
#872
Labels
Comments
Added in da72908 |
Awesome ❤️ Quick question, the linked commit says |
It should accept |
But the check is only for "pre": Line 189 in 775fa76
Or am I missing something? |
It only passes first 3 characters to the scripts. Lines 61 to 74 in 775fa76
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the feature
Most runners (be it GitHub-Hosted or Self-Hosted) have php versions pre-installed. For some workflows the performance is more important than the exact php version. So when targeting
ubuntu-24.04
it makes sense to use PHP 8.3, while onubuntu-22.04
it makes sense to use PHP 8.1. Therefore I was thinking if adding something likephp-version: preinstalled
orphp-version: highest-preinstalled
would make sense andsetup-php
would automatically choose the (highest) version that's already inside the image?Version
v2
.Underlying issue
Reduce bandwidth consumption and time to setup.
Describe alternatives
Manually adjust the workflows.
Additional context
Are you willing to submit a PR?
Generally yes, although no idea where to start.
The text was updated successfully, but these errors were encountered: