xfdesktop 4.19.0 - Icon-label color not transparent when other window is focused

[alexxcons]

Xfdesktop has focus:

Some other window has focus:

(Similar for greybird-dark)

I suppose this commit is related (though might not be the trigger of the original change): https://gitlab.xfce.org/xfce/xfdesktop/-/commit/6d991e6845966f69bc491055fcaf7c60a6123987

iirc, before the background-color was just fixed to transparent by xfdesktop, while now it is theme-specific (please correct me if I am wrong)

[alexxcons]

@kelnos hope it's correct this way ? I failed to find the relevant commit/issue in the xfdesktop gitlog.

[kelnos]

Yeah, looks right to me.

[andreldm]

I don't think that commit caused this issue, that is a fallback style, with Greybird that is not applied.

Anyway, please review and test: #338

[alexxcons]

Nice @andreldm !

Just tried to build stuff from master to test this, but failed for ./autogen.sh on xfdesktop:

./configure: line 19302: syntax error near unexpected token `X11,'
./configure: line 19302: `XDT_CHECK_OPTIONAL_FEATURE(X11,'

xfce4-dev-tools is up-to date ... any idea @kelnos ?

So I went back to xfdesktop 4.19.0, which buildsfine for me ... though I cannot reproduce the bug anymore 😒 (without having this MR applied yet) ... will try a re-login now .. who knows.

[kelnos]

@alexxcons you need xfce4-dev-tools 4.19.0. If you have it installed outside /usr, then you need to set XDT_PROG_AUTORECONF='autoreconf -I /other/prefix/share/aclocal'.

(Maybe xdt-autogen should automatically add to the include path if it's installed outside autoconf's prefix...)

[alexxcons]

I did not provide a prefix for xfce4-dev-tools, it installed into /usr (stuff was installed to /usr/local/bin). Just tried with dev-tools 4.19.0 instead of master, but same result.

If I put XDT_CHECK_OPTIONAL_FEATURE without argument, I get:

./configure: line 19302: XDT_CHECK_OPTIONAL_FEATURE: command not found

Hum, suppose I need to figure out why XDT_CHECK_OPTIONAL_FEATURE is not found for me.

[alexxcons]

Hmm, looks like something is broken on my autohell setup :/

When I add AC_CONFIG_MACRO_DIRS([/usr/local/share/aclocal]) to configure.ac, the relevant m4 files are found again. So I suppose that my default m4 lookup path is wrong/incomplete for whatever reason.

[kelnos]

I think that's expected. /usr/local is a nonstandard prefix; autoconf only looks in /usr/share/aclocal. So XDT_PROG_AUTORECONF='autoreconf -I /usr/local/share/aclocal' would probably work as well.

[alexxcons]

I think that's expected. /usr/local is a nonstandard prefix;

Oh, ok ... that is, what is used for me when I do not set a prefix, and where as well all my other self-build stuff goes 🙂.

Since I don't want to mess with prefixes each time I build something, I fixed that now in a rather drastic way 🙂

$ sudo cp aclocal/* /usr/share/aclocal
$ sudo rm -rf aclocal/
$ sudo ln -s /usr/share/aclocal

I just wonder why that was not a problem before ... probably related to me, using a new development machine.