Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tabs creates double borders in Thunar #313

Open
newhoa opened this issue Mar 9, 2022 · 2 comments
Open

Multiple tabs creates double borders in Thunar #313

newhoa opened this issue Mar 9, 2022 · 2 comments

Comments

@newhoa
Copy link
Contributor

newhoa commented Mar 9, 2022

In a Thunar window, if you open a new tab the border in the icon view (or detail/compact view) will have an additional border on all 4 sides.

Also, idk if this warrants another bug report but the color in between the tabs themselves doesn't match the background. Edit: This doesn't belong with this issue.

Thunar with no tabs

Thunar with tabs

@ochosi
Copy link
Member

ochosi commented Apr 27, 2022

This is sort of how it's supposed to look and how other tabs look, but I agree that it's not a great look.

We're still sticking to a style that is from Gtk2 times and built around Gtk2 limitations. With less and less applications still using Gtk2 and visual consistency there being a bit less of a thing I guess we could move on to another look.
I considered doing this a few times in the past but just never got around to redesigning them...

@newhoa
Copy link
Contributor Author

newhoa commented Jun 19, 2022

@ochosi I'm not sure if I explained the first part well. I wasn't referencing the border of the tab itself, but the border in the icon view area when tabs are opened. The easiest place to see this, in this picture, is between the icon view area and the sidebar -- but it doubles the border on all sides in the icon view (in the pic you can see a double border at the top under the inactive tab and on the right side of the window).

I tried this out in a few other themes and the added border does not seem to happen with Adwaita, Yaru, Numix, or Arc.

I'm not familiar enough with the theme to know how this would change other parts of the theme, but adding this to Gtk Inspector gave it the look that I think would be intended (here is the result). Not sure if it'll be any help but here it is.

/* This removes the border of the icon area only when there is a tab */

notebook stack:not(:only-child)
{
border-width: 0 0 0 0;
}

/* Keeping the top border above seems to create a */
/* double border on inactive tabs. */
/* This ensures the active tab has a bottom border */
/* without creating a double border for inactive tabs. */

notebook tab:checked
{
border-width: 1 1 1 1;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants