Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more magic #57

Open
shawngmc opened this issue Mar 29, 2023 · 0 comments
Open

Implement more magic #57

shawngmc opened this issue Mar 29, 2023 · 0 comments

Comments

@shawngmc
Copy link
Owner

Right now, the file identification code relies heavily on libmagic. While the libmagic integration is a little fragile, that can be improved separately.

The bigger concern is that the 'enhanced magic' is very limited:

  • Only a few types detected
  • All are hard-coded into the script

As such, the following improvements make sense

  • Move the custom magic to an JSON-based format
  • Add more magic detections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant