Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest pip version inconsistent - does not implement metrics_base_path #107

Open
tullis opened this issue Mar 11, 2016 · 0 comments
Open

Comments

@tullis
Copy link

tullis commented Mar 11, 2016

I have installed graphios from pip.
Thanks for your work on this tool, I think it's great.

I have been trying to implement a system which uses use_service_desc = True so it sends all of my metrics to graphite.

I have also decided to use a base path for all of my metrics, so I added metric_base_path = icinga to my config file. There was no commented template for this variable in my config file, so I had to add it.

The resulting whisper files are generated without this base path, so I started investigating why.

From my investigation it looks like the latest pip version is inconsistent and only includes some of the changes within this commit. Specifically these changes to graphios_backends.py don't seem to have been included.

2d6c078#diff-52a97f5de4dbf7f87c08baf311d76346L54

In addition to this, the change to graphios.cfg hasn't been included which explains not only why I had to add the configuration statement, but also it explains issue #95 as well.
2d6c078#diff-4df930f201411566ca416b64952a6420R52

I'm not going to make a pull request for it because I'm short of time, but hopefully this will help you to get the pip version up to date.

Once again, many thanks for this tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant