Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LegoSystem_BoostHub #133

Closed
LukeOwlclaw opened this issue Dec 27, 2020 · 3 comments
Closed

LegoSystem_BoostHub #133

LukeOwlclaw opened this issue Dec 27, 2020 · 3 comments
Labels
duplicate This issue or pull request already exists
Milestone
v3.4 (non-breaking)

Comments

@LukeOwlclaw
Copy link

I got hands on a Lego Boost and just noticed that

SystemType.LegoSystem_BoostHub

is defined but there is not BoostHub implementation. Is there anything going on on that front where I could chime in?
@tthiery
Copy link
Member

tthiery commented Dec 27, 2020 •
edited
Loading

There is nothing going on because I miss the hardware. Further, when I read/remember the node-poweredup library the boost hub is very different (using multiple bluetooth characteristics etc). It will significantly break all layers.

I am very open to contribution but it will be neither a small job nor easy 😁. I will help with all needed advice and assistance.

@tthiery
Copy link
Member

tthiery commented Dec 27, 2020 •
edited
Loading

Looks like I am wrong. I was confused with the WeDo 2.0 sets. I think the Boost hubs are called MoveHub in the library space. There is issue #95 Add Move Hub which seems pretty compliant which makes the whole adoptation a lot simpler. If you like you can throw yourself on that issue.

The owner of that issue @corneliusmunz is (I assume) pretty busy with the arduino world currently, so he is surely happy if you take that off his shoulders ;). There is an open branch in his fork.

@tthiery tthiery added this to the v3.4 (non-breaking) milestone Dec 30, 2020
@tthiery tthiery added the duplicate This issue or pull request already exists label Dec 30, 2020
@tthiery
Copy link
Member

tthiery commented Dec 30, 2020

Duplicate of #95. Will be added in #134

@tthiery tthiery closed this as completed Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
v3.4 (non-breaking)
Development

No branches or pull requests
2 participants
@tthiery @LukeOwlclaw