Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fox savings/could have saved. #8028

Open
Tracked by #8027
twblack88 opened this issue Oct 29, 2024 · 2 comments · May be fixed by #8531
Open
Tracked by #8027

add fox savings/could have saved. #8028

twblack88 opened this issue Oct 29, 2024 · 2 comments · May be fixed by #8531
Assignees
@woodenfurniture

Comments

@twblack88
Copy link
Contributor

twblack88 commented Oct 29, 2024 •
edited
Loading

Will probably need a quick spike on the logic and data for this experience.

[modal with you saved and twitter sharing-- and a "you could have saved with X]
https://www.figma.com/design/lqcttmmnGtRtbjb8evL6Le/FOX-page?node-id=1097-1519&node-type=frame&t=Psp4D7HPd0PYMGKP-11

Well need to think through pushing to fox simulator and the math we need to poll for the you could have saved bit.
@twblack88 twblack88 mentioned this issue Oct 29, 2024
Closed
3 tasks
@twblack88 twblack88 changed the title add fox savings and you could have saved. will probably need a quick spike on the logic and data for those. [spike and send] add fox savings/could have saved. Oct 29, 2024
@twblack88
Copy link
Contributor Author

twblack88 commented Dec 19, 2024 •
edited
Loading

Look, confetti thanks @reallybeard

Per @gomesalexandre :
We already have the data from the trade
how much you're charged and how much you would have saved. so on base case we have all the data to render the two states for fox holdings (saved, or didn't save). It's just delta between possible/actual BPS, prorated on the swap.

@0xean
Copy link
Contributor

0xean commented Jan 8, 2025 •
edited
Loading

If 100% - saved full amount
in between 100% discount - n% discount
If 0% - you could have saved full amount

change copy to "You could have saved up to XXX"

  • Link to simulator instead of Buy Fox (copy should read "Learn More")
  • Add a Buy FOX link to simulator (UI prefilled?)

image

If you saved nothing you see the bottom card
If you saved something you see the top card

@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Jan 8, 2025
@0xean 0xean changed the title [spike and send] add fox savings/could have saved. add fox savings/could have saved. Jan 8, 2025
@woodenfurniture woodenfurniture moved this from Up next / groomed to In progress in ShapeShift Dashboard Jan 9, 2025
@woodenfurniture woodenfurniture self-assigned this Jan 9, 2025
@woodenfurniture woodenfurniture linked a pull request Jan 10, 2025 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodenfurniture woodenfurniture

Labels
None yet
Projects
ShapeShift Dashboard
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: fox savings summary on trade success shapeshift/web
3 participants
@twblack88 @0xean @woodenfurniture