Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New trade flow: second hop confirm button is perma-loading #8469

Closed
gomesalexandre opened this issue Jan 6, 2025 · 1 comment · Fixed by #8493
Closed

New trade flow: second hop confirm button is perma-loading #8469

gomesalexandre opened this issue Jan 6, 2025 · 1 comment · Fixed by #8493
Assignees
Labels
bug Something isn't working

Comments

@gomesalexandre
Copy link
Contributor

gomesalexandre commented Jan 6, 2025

Overview

Steps to repro:

  • Initiate a multi-hop swap e.g USDC.ARB -> WETH.BASE
  • Notice how after first hop completion, second hop is perma-loading despite requirements passing
Screenshot 2025-01-06 at 12 46 32

Gut feel is hasClickedButton is set to true on first hop click, but never back to false thereafter when it should.

Note, this may well be a false flag due to second hop quote failing and will need to be repro'd deterministically to confirm it is an actual bug, else we can close this.

References and additional details

N/A

Acceptance Criteria

  • Able to execute second hop within new trade flow

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@0xean 0xean added the bug Something isn't working label Jan 6, 2025
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Jan 6, 2025
@gomesalexandre gomesalexandre self-assigned this Jan 7, 2025
@gomesalexandre
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants