Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unavailable swappers still have loading spinners #8395

Open
0xApotheosis opened this issue Dec 17, 2024 · 1 comment
Open

Unavailable swappers still have loading spinners #8395

0xApotheosis opened this issue Dec 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@0xApotheosis
Copy link
Member

Overview

When we have unavailable swappers after trade details have been input we still show loading spinners for each unavailable swapper. Whilst this might be technically true (we are still polling them), the user isn't expecting anything from those swappers with that given input.

We should probably not show the loading spinners here, as it doesn't make a lot of sense from a user perspective.

References and additional details

Screenshot 2024-12-17 at 09 34 49

Acceptance Criteria

Loading spinners are gone for unavailable swappers.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@0xApotheosis 0xApotheosis added the needs product Requires product input before bounty label Dec 17, 2024
@reallybeard
Copy link
Contributor

If a swapper is marked unavailable we should just show what swappers are unavailable, no other info. So a row with the icon is enough context.

I believe if its something the user can change to make the swapper active they are not considered unavailable.

So to sum it, remove the loading spinner, we don't need to show an error icon either. Just the name and the icon.

@reallybeard reallybeard added needs grooming and removed needs product Requires product input before bounty labels Jan 7, 2025
@0xean 0xean added bug Something isn't working and removed needs grooming labels Jan 8, 2025
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Up next / groomed
Development

No branches or pull requests

3 participants