Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Li.Fi final quote *failures* #8386

Closed
gomesalexandre opened this issue Dec 17, 2024 · 1 comment · Fixed by #8430
Closed

Handle Li.Fi final quote *failures* #8386

gomesalexandre opened this issue Dec 17, 2024 · 1 comment · Fixed by #8430
Assignees
Labels
bug Something isn't working

Comments

@gomesalexandre
Copy link
Contributor

Overview

This Li.Fi is to explicitly handle Li.Fi failures. Notice the emphasis on failures here, as opposed to "happy response, but final quote doesn't contain the previous quote from rate time".

We already handle the former following Li.Fi final quote work, Li.Fi final quote fix for bridges and Li.Fi final quote fix for unstable routes.

We should use the exact same logic as the latter in case Li.Fi fails on us at final quote time, which is v. possible if it's feeling cheeky at this particular moment (Li.Fi has its mood swings and may just fail because "why not, that's why") or if you as a user got limited between rate and quote.

References and additional details

Refer to Li.Fi final quote fix for unstable routes - exact same logic, except we want to catch HTTP failures instead of checking for !routes.length

Acceptance Criteria

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@0xean 0xean added the bug Something isn't working label Dec 18, 2024
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Dec 18, 2024
@gomesalexandre gomesalexandre self-assigned this Dec 20, 2024
@gomesalexandre
Copy link
Contributor Author

Deterministically reproducible by:

  • Ensuring you're not rate-limited already (fresh vpn server)
  • Getting a rate
  • Blocking request domain before getting quote
  • Notice bork ensue

See Jam: https://jam.dev/c/f11bcd66-84db-4cae-a227-4a5debe8c782

@gomesalexandre gomesalexandre moved this from Up next / groomed to In progress in ShapeShift Dashboard Dec 20, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants